Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteWatcher race-condition fix #3519

Merged
merged 2 commits into from
Jun 22, 2018
Merged

RemoteWatcher race-condition fix #3519

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23f9296
RemoteWatcher race-condition fix
zbynek001 Jun 21, 2018
e4a8d21
Merge branch 'dev' into remotewatcher-racecondition-fix
Aaronontheweb Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/core/Akka.Remote/RemoteWatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,10 +642,13 @@ private void ProcessTerminated(IInternalActorRef watchee, bool existenceConfirme

if (!addressTerminated)
{
foreach (var watcher in Watching[watchee])
if (Watching.TryGetValue(watchee, out var watchers))
{
// ReSharper disable once ConditionIsAlwaysTrueOrFalse
watcher.SendSystemMessage(new DeathWatchNotification(watchee, existenceConfirmed, addressTerminated));
foreach (var watcher in watchers)
{
// ReSharper disable once ConditionIsAlwaysTrueOrFalse
watcher.SendSystemMessage(new DeathWatchNotification(watchee, existenceConfirmed, addressTerminated));
}
}
}

Expand Down