Using nonblocking task completion source hack for Source.Queue #3692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we
Source.Queue<>
method, it can be materialized into queue withOfferAsync
method. Problem is that, awaiting for it may cause a deadlock - it's a classical problem with awaiting on theTaskCompletionSource<>.Task
and usingSetResult
on that task in the same execution context. We already met it before.This issue is easy to fix in .NET Standard 2.0 by using special option when creating
TaskCompletionSource<>
. For .NET Standard < 1.6 we already provided a hack around it (which usesTask.Run
to escape from execution context): it's suboptimal, but it's used only for older framework versions.This PR uses our fixer method set to overcome this deadlock issue.
Example, I've used to recreate this issue, was a Akka.Streams TCP server:
And client: