Fixed logic on how to get current events by tag in batches #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptjhuang
changed the title
ptjhuang
changed the title
|
Tests failed in areas I didn't change? |
|
@ptjhuang yeah that's our fault - racy unit tests that we haven't debugged yet. I'll take a look at it and do a proper review on this PR. Sorry for the delay - been traveling in Europe for work :p |
|
@Aaronontheweb I'm running into this issue as well, do you have an ETA on when this will be merged in? |
|
@ericphan I'll look at it today |
Aaronontheweb
approved these changes
Feb 26, 2019
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3697
Looking at the Scala LevelDb implementation, it looks like they have a special "$$$tag" persistence-id that stores the highest sequence number.
Most SQL database are fairly good at getting highest value of an indexed column, so it's done as a separate query.