Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input type for error message relating to open issue #3731

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

izavala
Copy link
Contributor

@izavala izavala commented Mar 6, 2019

Change to exception message in relation to open issue #3292.

The exception message seems to be taking in the incorrect input at the end of the message. The if statement is making sure mqType.Value is a subclass of actorRequirement.Value and as such the exception error message should state
$"Must be a subclass of [{actorRequirement.Value}]");
rather than
$"Must be a subclass of [{mqType.Value}]");
if this condition is not met.

@Aaronontheweb Aaronontheweb added this to the 1.3.12 milestone Mar 7, 2019
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb removed this from the 1.3.12 milestone Mar 7, 2019
@Aaronontheweb Aaronontheweb merged commit 4f0fbb8 into akkadotnet:dev Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants