BatchingSqlJournal now preserves Sender in PersistCallback #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Horusiath mind validating this, or suggesting an alternative solution? |
|
OK
Le dim. 5 mai 2019 à 15:29, Ismael Hamed <notifications@github.com> a
écrit :
… @Horusiath <https://github.com/Horusiath> mind validating this, or
suggesting and alternative solutions?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3779 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKKIIENDJ7DWAPDEOPX56GTPT3OMLANCNFSM4HK3ICMA>
.
|
Horusiath
requested changes
May 6, 2019
| @@ -10,6 +10,10 @@ | |||
| <NetStandardImplicitPackageVersion Condition=" '$(TargetFramework)' == 'netstandard1.6' ">1.6.1</NetStandardImplicitPackageVersion> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.ValueTuple" Version="4.5.0" /> | |||
There was a problem hiding this comment.
While I'd like to move to value tuples, I think this is a change to be done directly on Akka core package ;)
ismaelhamed
force-pushed
the
journal-fix-sender
branch
from
c958bdd to
c22ed96
Compare
ismaelhamed
force-pushed
the
journal-fix-sender
branch
from
c22ed96 to
0dd0c71
Compare
ismaelhamed
changed the title
|
You good with the updates @Horusiath ? |
Horusiath
approved these changes
May 7, 2019
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, you have to capture Sender before calling Persist() when you use the BatchingSqlJournal, otherwise you end up with the wrong Sender in the PersistCallback.