treat some deserialization errors as transient in remoting #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek001
changed the title
|
this is a very welcome change I've been wanting to add myself. Thanks for handling it! I'll review it as soon as I can. |
…0641 * to be able to introduce new messages and still support rolling upgrades, i.e. a cluster of mixed versions * note that it's only catching NotSerializableException, which we already use for unknown serializer ids and class manifests * note that it is not catching for system messages, since that could result in infinite resending Do not tear down connections on IllegalArgumentException from serializer, Migrated from #24910
zbynek001
force-pushed
the
drop-association
branch
from
a9b670d to
a5ad71c
Compare
Aaronontheweb
approved these changes
May 21, 2019
| @@ -157,7 +158,7 @@ public override object FromBinary(byte[] bytes, string manifest) | |||
| if (_fromBinaryMap.TryGetValue(manifest, out var factory)) | |||
| return factory(bytes); | |||
|
|
|||
| throw new ArgumentException($"Unimplemented deserialization of message with manifest [{manifest}] in [{this.GetType()}]"); | |||
| throw new SerializationException($"Unimplemented deserialization of message with manifest [{manifest}] in [{this.GetType()}]"); | |||
|
|
||
|
|
||
| [Fact] | ||
| public void The_transport_must_stay_alive_after_a_transient_exception_from_the_serializer() |
| ackAndMessage.MessageOption.RecipientAddress, | ||
| ackAndMessage.MessageOption.SerializedMessage, | ||
| ackAndMessage.MessageOption.SenderOptional); | ||
| try |
| /// if the manifest is unknown.This makes it possible to introduce new message | ||
| /// types and send them to nodes that don't know about them. This is typically | ||
| /// needed when performing rolling upgrades, i.e.running a cluster with mixed | ||
| /// versions for while. <see cref="SerializationException"/> is treated as a transient |
There was a problem hiding this comment.
Comment is helpful and descriptive
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
…0641 (akkadotnet#3782) * to be able to introduce new messages and still support rolling upgrades, i.e. a cluster of mixed versions * note that it's only catching NotSerializableException, which we already use for unknown serializer ids and class manifests * note that it is not catching for system messages, since that could result in infinite resending Do not tear down connections on IllegalArgumentException from serializer, Migrated from #24910
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
…0641 (akkadotnet#3782) * to be able to introduce new messages and still support rolling upgrades, i.e. a cluster of mixed versions * note that it's only catching NotSerializableException, which we already use for unknown serializer ids and class manifests * note that it is not catching for system messages, since that could result in infinite resending Do not tear down connections on IllegalArgumentException from serializer, Migrated from #24910
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
…0641 (akkadotnet#3782) * to be able to introduce new messages and still support rolling upgrades, i.e. a cluster of mixed versions * note that it's only catching NotSerializableException, which we already use for unknown serializer ids and class manifests * note that it is not catching for system messages, since that could result in infinite resending Do not tear down connections on IllegalArgumentException from serializer, Migrated from #24910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
treat some deserialization errors as transient in remoting
Migrated from
akka/akka#20641
akka/akka#24910