Fix repeatable failure of a "Tail_chopping_group_router" test case #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_if_no_result_will_arrive_within_the_given_time test case.
|
These changes have been rolled into #3790. Will close this in favour of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that the Tail_chopping_group_router_must_throw_exception_if_no_result_will_arrive_within_the_given_time test case in the Akka.Tests project consistently fails.
While I may be missing something, I think that the reason is because the timeout of an Ask operation throws an AskTimeoutException rather than TaskCanceledException. The latter is only for when the request is explicitly cancelled using the token.
Adding the extra catch clause fixes that test.