Remove return of force exit task in coordinated shutdown #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwpro I wouldn't worry about a reproduction spec for this - as you point out, the |
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3815
I've removed the return statement in front of force exit task, which was making code responsible for actual terminating of actor system unreachable when both terminate-actor-system and exit-clr are enabled.
Sorry for not writing any tests but I didn't figure out how to write unit test for code containing
Environment.Exit(0)(which causes whole test suite to exit).