fixed issue with multiple specs all trying to use same Akka.Remote port at the same time #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use same Akka.Remote port at the same time
|
I think I addressed this inside #3744 using |
|
This is a more heavy-duty change, but I think it's the right way to handle this: if we're going to run the TestSuite concurrently, have everything use port 0 by default. Any HOCON supplied on an individual test will override this. |
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
…rt at the same time (akkadotnet#3817) * part of akkadotnet#3786 - fixed issue with multiple specs all trying to use same Akka.Remote port at the same time * updated specs to use Collections XUnit attribute instead * use port 0 in all specs by default
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 30, 2019
…rt at the same time (akkadotnet#3817) * part of akkadotnet#3786 - fixed issue with multiple specs all trying to use same Akka.Remote port at the same time * updated specs to use Collections XUnit attribute instead * use port 0 in all specs by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3786