ShardStats and ClusterShardingStats serialization fix #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready to go - will fix #3830 |
Horusiath
reviewed
Jul 10, 2019
| {EntityStateManifest, EntityStateFromBinary}, | ||
| {EntityStartedManifest, EntityStartedFromBinary}, | ||
| {EntityStoppedManifest, EntityStoppedFromBinary}, | ||
| {EntityStateManifest, bytes => EntityStateFromBinary(bytes) }, |
There was a problem hiding this comment.
I prefer using method straight away instead of lambda syntax - I don't know it lambda syntax will trigger generation of hidden class representing it, but this way I'm sure I don't give a compiler reasons to think it should try so.
There was a problem hiding this comment.
The existing serializer does a mix of both already and these messages aren't sent very often.
src/contrib/cluster/Akka.Cluster.Sharding/Serialization/ClusterShardingMessageSerializer.cs
Outdated
Show resolved
Hide resolved
src/contrib/cluster/Akka.Cluster.Sharding/Serialization/ClusterShardingMessageSerializer.cs
Show resolved
Hide resolved
|
Addressed comments |
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
* close akkadotnet#3830 - added serialization support for ClusterShardingStats
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 21, 2019
* close akkadotnet#3830 - added serialization support for ClusterShardingStats
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 26, 2019
* close akkadotnet#3830 - added serialization support for ClusterShardingStats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.