Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't passivate idle for remembering entities #3833

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

ismaelhamed
Copy link
Member

Port #27177

@ismaelhamed ismaelhamed changed the title Don't passivate idle for remembering entities [WIP] Don't passivate idle for remembering entities Jun 28, 2019
@ismaelhamed
Copy link
Member Author

Some tests seem to be failing, I'll look into it.

@ismaelhamed ismaelhamed force-pushed the passivate-vs-remembering branch from 58436cd to 2d22e29 Compare June 28, 2019 09:51
@ismaelhamed
Copy link
Member Author

So we had one outdated test, and another one that is not needed anymore because having remember entities enabled will now disable passivate idle.

This is now ready to go.

@ismaelhamed ismaelhamed changed the title [WIP] Don't passivate idle for remembering entities Don't passivate idle for remembering entities Jun 28, 2019
@Horusiath Horusiath self-requested a review July 1, 2019 06:34
Copy link
Contributor

@Horusiath Horusiath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@Horusiath Horusiath merged commit 18aa2c1 into akkadotnet:dev Jul 1, 2019
@Aaronontheweb Aaronontheweb added this to the 1.4.0 milestone Jul 3, 2019
madmonkey pushed a commit to madmonkey/akka.net that referenced this pull request Jul 12, 2019
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this pull request Jul 21, 2019
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants