Persistence TestKit documentation article #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valdisz
force-pushed
the
feature/persistence-testkit-docs
branch
from
d649835 to
d6bcdf7
Compare
|
Part of #3877 |
|
@Aaronontheweb do you like wording better? Can I continue in the same manner? |
|
@valdisz I'll take a look at it, since I would really love to have this up on the website to go along with the v1.4.0-beta2 release we just pushed |
|
@Aaronontheweb so... do you like it now? |
Aaronontheweb
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Content looks good, but the tests are failing - any idea why @valdisz ?
| @@ -0,0 +1,179 @@ | |||
| --- | |||
| uid: persistence-testing | |||
| title: Persistence Testing | |||
There was a problem hiding this comment.
Let's rename this to something more descriptive: "Testing Persistence Akka.NET Actors"
| @@ -69,14 +70,17 @@ public class CounterActorTests : PersistenceTestKit | |||
| [Fact] | |||
| public async Task CounterActor_internal_state_will_be_lost_if_underlying_persistence_store_is_not_available() | |||
| { | |||
| await WithJournalWrite(write => write.Fail(), () => | |||
| await WithJournalWrite(write => write.Fail(), async () => | |||
|
Looks like you forgot to add the article to the |
|
@sean-gilliam ah shit - mind sending in a PR for that? |
|
@Aaronontheweb Sure thing #4001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new article which will cover new Persistence TestKit.