Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singleton - missing state change fix #4003

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

zbynek001
Copy link
Contributor

introduced in #3962

@Aaronontheweb
Copy link
Member

@zbynek001 nice catch

@Aaronontheweb Aaronontheweb added this to the 1.4.0 milestone Oct 24, 2019
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -728,7 +728,7 @@ private void InitializeFSM()

if (youngerData.Oldest.All(m => _removed.ContainsKey(m)))
{
GoToOldest();
return GoToOldest();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 7966624 into akkadotnet:dev Oct 24, 2019
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this pull request Nov 14, 2019
@zbynek001 zbynek001 deleted the singleton-fix branch March 18, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants