disable Akka.Remote DotNetty batching system inside TestKit by default #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08c14cc.
…ed_deliveries_with_an_initially_in_order_strategy_before_delivering_fresh_messages as skipped
…i_must_not_signal_error_if_traffic_is_one_way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been an increase in flaky Akka.Remote tests, and I think #4106 is the likely culprit - since adding those additional ~40ms delays can make it more difficult for some tests with tight time parameters to pass. By default in the TestKit going forward we'll have the batching system disabled via HOCON.
Per #3786