Fixes actor ref leak in AddressTerminatedTopic (#4304) #4305
Conversation
…immediately after unwatching a remote actor.
petrikero
changed the title
|
The failing .NET Framework Unit Tests seem to me to be unrelated, but I'm not sure I'm reading the outputs correctly. |
|
@petrikero the v1.3 branch is missing a bunch of racy spec fixes we introduced in the v1.4 / dev branch. I'll take a look at these. |
|
Thanks! The issues are crashing our systems after a few days of running, so they're pretty critical for us. I did manage to inject a custom-built Akka.dll (with the two PRs included) into our build pipeline to solve the bleeding for now. If there's anything more I can do to help get them merged, please let me know. I'll be happy to help, but am a bit at a loss with the size of the project. :) |
|
failed specs appear to be largely the result of:
|
| @@ -173,7 +173,10 @@ protected void TellWatchersWeDied() | |||
| } | |||
| finally | |||
| { | |||
| _state = _state.ClearWatching(); | |||
| MaintainAddressTerminatedSubscription(() => | |||
There was a problem hiding this comment.
Wow, this is an old bug. Looks right though.
|
I'll see about having us to a v1.3.18 release to fix these. |
…immediately after unwatching a remote actor. (akkadotnet#4305)
I made the PR against v1.3 as that's what we're using and where I could confirm the bug and the fix.