Allow different versions of MS Abstractions nuget package for Akka.DependencyInjection #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
I'm at odds about what to do here to some extent largely because I'm not sure whether this is going to introduce a new set of problems.
The other alternative is just multi-targeting, which we can certainly do... But we have been trying to avoid that.
I think we should do a quick release with this included and see how things go, since .NET Core 3.1 seems to be the dominant one and the only real stable release. .NET 5 users should be able to roll-forward on top of this without any issues either.
Aaronontheweb
added a commit
that referenced
this pull request
Jan 22, 2021
#### 1.4.16 January 22 2021 #### **Maintenance Release for Akka.NET 1.4** This is a tiny release of Akka.NET, aimed at solving a transient dependency issue with Akka.DependencyInjection: * [Akka.DependencyInjection: Allow different versions of MS Abstractions nuget package for Akka.DependencyInjection](#4739) - rolls back to Microsoft.Extensions.DependencyInjection.Abstractions 3.1 instead of 5.0
Aaronontheweb
added a commit
that referenced
this pull request
Jan 22, 2021
#### 1.4.16 January 22 2021 #### **Maintenance Release for Akka.NET 1.4** This is a tiny release of Akka.NET, aimed at solving a transient dependency issue with Akka.DependencyInjection: * [Akka.DependencyInjection: Allow different versions of MS Abstractions nuget package for Akka.DependencyInjection](#4739) - rolls back to Microsoft.Extensions.DependencyInjection.Abstractions 3.1 instead of 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of multi-targeting, we can just allow lower versions of MS nuget package to be used, since all we need is
ActivatorUtilitieswhich exists in a wide version range of that package.