-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORDictionary with POCO value missing items, add MultiNode spec #4910
Merged
Aaronontheweb
merged 11 commits into
akkadotnet:dev
from
Arkatufus:#4843_ORDictionary_with_POCO_value_missing_items
Apr 23, 2021
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
28e9ad0
Update DData reference HOCON config to follow JVM
Arkatufus f9f0821
Clean up ReplicatorSettings, add sensible default values.
Arkatufus 96f80fd
Add DurableData spec that uses ORDictionary with POCO values
Arkatufus 58a9c1b
Add a special case for Replicator to suppress messages during load
Arkatufus 28534b2
Merge branch 'dev' into #4843_ORDictionary_with_POCO_value_missing_items
Arkatufus ae7a79e
Slight change in public API, behaviour is identical.
Arkatufus 14de2ce
Merge branch 'dev' into #4843_ORDictionary_with_POCO_value_missing_items
Arkatufus d9c8026
Merge branch 'dev' into #4843_ORDictionary_with_POCO_value_missing_items
Arkatufus 56a2bd4
Change Replicator class to UntypedActor
Arkatufus 9201abc
Code cleanup - Change fields to properties
Arkatufus 1a7d62d
Update API Approver list
Arkatufus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change Replicator class to UntypedActor
commit 56a2bd4b0f1c17e21c24591611eaf540a4c8e33b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is practically the same, needed to change it to untyped receive so that we can call it from somewhere else and checks if it handled the message or not (partial function in scala)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And that works even with a
ReceiveActor
? Never tried that before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I should probably change the base class to
UntypedActor
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me