Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turned HeatbeatNodeRing into struct #4944

Merged
merged 13 commits into from
Apr 19, 2021
Merged

Turned HeatbeatNodeRing into struct #4944

merged 13 commits into from
Apr 19, 2021

Commits on Apr 17, 2021

  1. added benchmark for HeartbeatNodeRing performance

    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    2af135c View commit details
    Browse the repository at this point in the history

  2. switched to local function 

    No perf change
    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    6bc7db5 View commit details
    Browse the repository at this point in the history

  3. approve Akka.Benchmarks friend assembly for Akka.Cluster

    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    008e794 View commit details
    Browse the repository at this point in the history

  4. remove HeartbeatNodeRing.NodeRing() allocation and make field immutable

    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    d5e98d2 View commit details
    Browse the repository at this point in the history

  5. made it so Akka.Util.Internal.ArrayExtensions.From no longer allocate… 

    …s (much)
    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    2cbf1f6 View commit details
    Browse the repository at this point in the history

  6. added some descriptive comments on HeartbeatNodeRing.Receivers

    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    56cc274 View commit details
    Browse the repository at this point in the history

  7. Replaced Lazy<T> with Option<T> and a similar lazy initialization… 

    … check

 Improved throughput by ~10% on larger collections and further reduced memory allocation.
    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    220f237 View commit details
    Browse the repository at this point in the history

  8. changed return types to IImmutableSet 

    Did this in order to reduce allocations from constantly converting back and forth from `ImmutableSortedSet<T>` and `ImmutableHashSet<T>` - that way we can just use whatever the underlying collection type is.
    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    b289836 View commit details
    Browse the repository at this point in the history

  9. converted HeartbeatNodeRing into a struct 

    improved performance some, but I don't want to lump it in with other changes just in case
    @Aaronontheweb
    Aaronontheweb committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    66868a9 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into cluster/heartbeatnodeRing-struct

    @Aaronontheweb
    Aaronontheweb authored Apr 17, 2021
    Configuration menu
    Copy the full SHA
    6c4ea4b View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. Merge branch 'dev' into cluster/heartbeatnodeRing-struct

    @Aaronontheweb
    Aaronontheweb authored Apr 18, 2021
    Configuration menu
    Copy the full SHA
    bfa8f57 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Merge branch 'dev' into cluster/heartbeatnodeRing-struct

    @Aaronontheweb
    Aaronontheweb authored Apr 19, 2021
    Configuration menu
    Copy the full SHA
    34ecd46 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into cluster/heartbeatnodeRing-struct

    @Aaronontheweb
    Aaronontheweb authored Apr 19, 2021
    Configuration menu
    Copy the full SHA
    d583946 View commit details
    Browse the repository at this point in the history