SBR fix & update #5147
Merged
SBR fix & update #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might take me a bit longer to get to reviewing this one, but I will do my best! |
Aaronontheweb
approved these changes
Aug 2, 2021
| using Akka.Event; | ||
| using Akka.TestKit; | ||
| using Akka.TestKit.Xunit2; | ||
| using Akka.Util; | ||
|
|
||
| namespace Akka.Cluster.Tools.Tests | ||
| namespace Akka.Coordination.Tests |
There was a problem hiding this comment.
Most of the changes in this PR are due to moving this file around, so this PR is actually simpler than it appears.
| public LeaseMajoritySettings(string leaseImplementation, System.TimeSpan acquireLeaseDelayForMinority, string role, string leaseName) { } | ||
| public LeaseMajoritySettings(string leaseImplementation, System.TimeSpan acquireLeaseDelayForMinority, System.TimeSpan releaseAfter, string role, string leaseName) { } |
| } | ||
|
|
||
| protected DownAllIndirectlyConnected5NodeSpec(DownAllIndirectlyConnected5NodeSpecConfig config) | ||
| : base(config, typeof(DownAllIndirectlyConnected5NodeSpec)) |
There was a problem hiding this comment.
MNTR constructors and config all look fine
| { | ||
| AwaitAssert(() => | ||
| { | ||
| cluster.State.Members.Select(i => i.Address).Should().BeEquivalentTo(Node(_config.Node1).Address); |
There was a problem hiding this comment.
So all of the nodes that have at least one broken connection are downed...
| { | ||
| cluster.State.Unreachable.Select(i => i.Address).Should().BeEquivalentTo(new[] { _config.Node1, _config.Node2, _config.Node3 }.Select(i => Node(i).Address)); | ||
| }, _config.Node4, _config.Node5); | ||
| }); |
There was a problem hiding this comment.
The partitions here make sense [1,2,3] and [4.5]
| // now it should have been unstable for more than 17 seconds | ||
|
|
||
| // all downed | ||
| AwaitCondition(() => cluster.IsTerminated, max: TimeSpan.FromSeconds(15)); |
| { | ||
| AwaitAssert(() => | ||
| { | ||
| Cluster.State.Members.Count.Should().Be(3); |
There was a problem hiding this comment.
Nodes that couldn't acquire the Lease have been downed here
| @@ -2639,7 +2639,7 @@ public void AssertLatestGossip() | |||
| public void PublishMembershipState() | |||
| { | |||
| if (_cluster.Settings.VerboseGossipReceivedLogging) | |||
| _log.Debug("Cluster Node [{0}] - New gossip published [{0}]", SelfUniqueAddress, _membershipState.LatestGossip); | |||
| _log.Debug("Cluster Node [{0}] - New gossip published [{1}]", SelfUniqueAddress, _membershipState.LatestGossip); | |||
Aaronontheweb
added
akka-cluster
akka-coordination
This was referenced Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Become after acquire lease
Updated: