Remove LightningDB reference in cluster sharding, make ddata non-durable as default #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,8 +184,10 @@ akka.cluster.sharding { | |||
| distributed-data { | |||
| # minCap parameter to MajorityWrite and MajorityRead consistency level. | |||
| majority-min-cap = 5 | |||
|
|
|||
| durable.keys = ["shard-*"] | |||
There was a problem hiding this comment.
Do you recall why we added this in the first place?
There was a problem hiding this comment.
It was in the official JVM reference.conf, I didn't know that our default value is different than theirs
There was a problem hiding this comment.
Well it seems that our issue really comes down to the .NET LightningDb packages not having all of the native dependencies they need. We'll add this setting back when we move the default for Akka.Cluster.Sharding state store mode away from persistence and to DData.
|
|
||
| # Uncomment this line if you want to use the durable version of DData and make sure that | ||
| # you also reference the Akka.DistributedData.LightningDB nuget package. | ||
| # durable.keys = ["shard-*"] |
There was a problem hiding this comment.
Make sure we tell users to add this setting back in the documentation (in the other PR you're working on)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.