Use TimestampProvider in BatchingSqlJournal #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Aug 11, 2021
There was a problem hiding this comment.
LGTM, but need to approve the public API changes via https://getakka.net/community/public-api-changes.html
src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/BatchingSqlJournal.cs
Show resolved
Hide resolved
| @@ -1286,7 +1299,7 @@ private async Task<WriteMessagesResult> HandleWriteMessages(WriteMessages req, T | |||
| persistent = persistent.WithPayload(tagged.Payload); | |||
| } | |||
|
|
|||
| WriteEvent(command, persistent.WithTimestamp(DateTime.UtcNow.Ticks), tagBuilder.ToString()); | |||
| WriteEvent(command, persistent.WithTimestamp(TimestampProvider.GenerateTimestamp(persistent)), tagBuilder.ToString()); | |||
Aaronontheweb
approved these changes
Aug 14, 2021
to11mtm
reviewed
Aug 14, 2021
src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/ITimestampProvider.cs
Outdated
Show resolved
Hide resolved
…rtijnSchoemaker/akka.net into TimestampProviderInBatchingSqlJournal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5077 fixed using timestamp provider for SqlJournal.
With this new PR the timestamp provider will be used in BatchingSqlJournal as well.