Added telemetry injection point for Ask<T>
#5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking for a way to help trace timeouts inside `Ask<T>` operations - needed some way to tap into the `TaskCompletionSource` and to create an active `ISpan` before the operation begins.
Aaronontheweb
commented
Oct 5, 2021
| @@ -1561,8 +1561,9 @@ public void StopSeedNodeProcess() | |||
| /// Received `Join` message and replies with `Welcome` message, containing | |||
| /// current gossip state, including the new joining member. | |||
| /// </summary> | |||
| /// <param name="node">TBD</param> | |||
| /// <param name="roles">TBD</param> | |||
| /// <param name="node">The unique address of the joining node.</param> | |||
There was a problem hiding this comment.
Unrelated XML-DOC fix I made to resolve a compiler warning.
Aaronontheweb
commented
Oct 5, 2021
| /// <typeparam name="T">The type of output this <see cref="FutureActorRef{T}"/> expects.</typeparam> | ||
| /// <returns>A new, single-use <see cref="FutureActorRef{T}"/> instance.</returns> | ||
| [InternalApi] | ||
| FutureActorRef<T> CreateFutureRef<T>(TaskCompletionSource<T> tcs); |
There was a problem hiding this comment.
New InternalApi, but still public member on the IActorRefProvider interface. This is our injection point.
Aaronontheweb
commented
Oct 5, 2021
| //create a new tempcontainer path | ||
| var path = provider.TempPath(); | ||
|
|
||
| var future = new FutureActorRef<T>(result, path, provider); |
There was a problem hiding this comment.
Moved these two lines to the factory method - all of the TCS setup is left as-is.
|
@Arkatufus thanks - still integration testing this with Phobos to make sure it actually works first. |
|
Validated this on our end - looking good there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for a way to help trace timeouts inside
Ask<T>operations - needed some way to tap into theTaskCompletionSourceand to create an activeISpanbefore the operation begins.