Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNTR] Migrate to standalone MNTR #5307

Merged
merged 10 commits into from
Oct 20, 2021

Conversation

Arkatufus
Copy link
Contributor

No description provided.

@Arkatufus Arkatufus marked this pull request as draft October 11, 2021 22:27
@Arkatufus Arkatufus marked this pull request as ready for review October 19, 2021 16:03
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions

@@ -3,7 +3,7 @@

<PropertyGroup>
<AssemblyTitle>Akka.Cluster.Sharding.Tests.MultiNode</AssemblyTitle>
<TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, we're dropping .NET Framework MNTR specs for this right?

mntrFailuresDir: 'TestResults\\multinode'
mntrFailuresArtifactName: "net_fx_mntr_FAILED_windows-$(Build.BuildId)"

- template: azure-pipeline.mntr-template.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do we need this mtnr-template.yaml anymore?

@Aaronontheweb Aaronontheweb merged commit 72798d6 into akkadotnet:dev Oct 20, 2021
@Aaronontheweb Aaronontheweb added this to the 1.4.28 milestone Oct 20, 2021
@Aaronontheweb Aaronontheweb added multi node spec akka-testkit Akka.NET Testkit issues labels Oct 20, 2021
@Arkatufus Arkatufus deleted the MNTR_migrate_to_standalone branch February 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-testkit Akka.NET Testkit issues multi node spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants