Fix DefaultResizer for suspended mailboxes (ReceiveAsync) #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/Akka/Routing/Resizer.cs
Outdated
| @@ -226,6 +226,9 @@ public int Pressure(IEnumerable<Routee> currentRoutees) | |||
| var underlying = actorRef.Underlying; | |||
| if (underlying is ActorCell cell) | |||
| { | |||
| if (cell.Mailbox.IsSuspended() && cell.Mailbox.NumberOfMessages >= PressureThreshold) | |||
| @@ -266,6 +285,55 @@ public void DefaultResizer_must_grow_as_needed_under_pressure() | |||
| RouteeSize(router).Should().Be(resizer.UpperBound); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task DefaultResizer_with_ReceiveAsync_must_grow_as_needed_under_pressure() | |||
There was a problem hiding this comment.
How does this test perform? Resizer specs are notoriously racy, but if we force the Resizer to spin up more actors while the current ones are await-ing over a sufficiently long duration that should be reasonably stable.
Aaronontheweb
approved these changes
Oct 20, 2021
Aaronontheweb
requested changes
Oct 20, 2021
…:Arkatufus/akka.net into #5327_ReceiveAsync_breaks_DefaultResizer
Aaronontheweb
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5327