Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Add extra help information on serializer id errors #5418

Merged
merged 8 commits into from
Dec 8, 2021

Conversation

Arkatufus
Copy link
Contributor

No description provided.

@Arkatufus Arkatufus marked this pull request as draft December 7, 2021 21:03
@Arkatufus
Copy link
Contributor Author

Arkatufus commented Dec 7, 2021

Written documentation is not complete yet, code is complete.

@Arkatufus Arkatufus marked this pull request as ready for review December 7, 2021 21:57
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -202,3 +202,5 @@
href: utilities/circuit-breaker.md
- name: Configurations
href: configuration/toc.yml
- name: Serialization
href: serialization/toc.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably migrate some stuff to this section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a plan on moving Hyperion to its own page, so I think this section would host it.

@Aaronontheweb
Copy link
Member

This should help quite a bit when debugging serialization configuration errors.

@Aaronontheweb Aaronontheweb merged commit 1382b3c into akkadotnet:dev Dec 8, 2021
@Arkatufus Arkatufus deleted the DOC_Serializer_Id branch December 13, 2021 21:10
@Arkatufus Arkatufus restored the DOC_Serializer_Id branch April 22, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants