MDB throws a MDB_NOTFOUND exception when the database directory already exists #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Try to recreate the database even when directory exists.
…a.net into #5423_LMDB_directory_crash
Arkatufus
commented
Dec 10, 2021
src/contrib/cluster/Akka.DistributedData.LightningDB/LmdbDurableStore.cs
Show resolved
Hide resolved
Arkatufus
commented
Dec 10, 2021
| { | ||
| try | ||
| using (var env = GetLightningEnvironment()) |
There was a problem hiding this comment.
Might as well re-arrange the try...catch block to include the LMDB environment initialization code so it can catch exceptions thrown there
Arkatufus
commented
Dec 10, 2021
| { | ||
| try | ||
| { | ||
| foreach (var entry in _pending) | ||
| using (var db = tx.OpenDatabase(DatabaseName)) |
There was a problem hiding this comment.
Same as above, rearranged the try...catch block
Aaronontheweb
approved these changes
Dec 13, 2021
src/contrib/cluster/Akka.DistributedData.LightningDB/LmdbDurableStore.cs
Show resolved
Hide resolved
Failed on Windows with .NET Framework. |
|
I can't replicate that failure locally, i think it has something to do with the test file system |
…iles were copied over
|
Oh, it was this problem all over again: CoreyKaylor/Lightning.NET#104 |
| @@ -5,6 +5,7 @@ | |||
| <PropertyGroup> | |||
| <AssemblyTitle>Akka.DistributedData.Tests</AssemblyTitle> | |||
| <TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks> | |||
| <PlatformTarget>x64</PlatformTarget> | |||
There was a problem hiding this comment.
Might want to add a comment explaining why this is necessary - feel free to add it in a new PR @Arkatufus
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5423