Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize Props NewExpression allocations #5428

Merged
merged 6 commits into from
Dec 20, 2021

Conversation

Aaronontheweb
Copy link
Member

Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 17, 2021 21:42
@Aaronontheweb Aaronontheweb merged commit 42501db into akkadotnet:dev Dec 20, 2021
@Aaronontheweb Aaronontheweb deleted the perf/props-NewArgs-opt branch December 20, 2021 15:03
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Dec 20, 2021
Aaronontheweb added a commit that referenced this pull request Dec 20, 2021
)

* remove the forced waiting on the underlying transport to start up

* racy spec fix: `BackoffOnRestartSupervisor_must_respect_maxNrOfRetries_property_of_OneForOneStrategy` (#5442)

issue was that using `AutoReset` could cause a race where if the scheduler could reset the count in-flight and throw off the estimates used by the tests. Using a `ManualReset` avoids this issue.

* deleted commented out code

* Make updates to `FishUntil` (#5433)

* Make updates to `FishUntil`

Implement nitpicks from #5430

* Nitpick

* cleaned up `FishUntilMessage`

* removed `FluentAssertions` reference

* fixed bad `TestKit.ReceiveTests`

* Custom frame size computation support in Framing (#5444)

* Custom frame size computation support in Framing

* Speed up of framing spec

* optimize `Props` `NewExpression` allocations (#5428)

per #5416 (comment)

Co-authored-by: Ismael Hamed <1279846+ismaelhamed@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants