Add Flow.LazyInitAsync, and fix materialized value of Sink.LazyInit #5476
Conversation
ismaelhamed
changed the title
|
I must add the documentation before this can be merged. |
|
@ismaelhamed did my new pull request template pop up when you submitted this? Still trying to see if I set that up correctly last week. |
Yes. Would you prefer it if I follow the template strictly? |
I think it would be helpful going forward but I also need feedback on it to see if it actually is helpful to both reviewers and contributors. You're an experienced contributor so I would welcome any critical feedback you have on them. Best place to do it is probably in our meta-repo where the PR templates are defined: https://github.com/akkadotnet/.github |
ismaelhamed
force-pushed
the
flow-lazyinit
branch
from
bccab5d
to
7f97640
Compare
|
@Aaronontheweb documentation added, and PR template updated. This is ready for review. |
ismaelhamed
changed the title
ismaelhamed
force-pushed
the
flow-lazyinit
branch
from
7f97640
to
782a539
Compare
|
Looks like you have some unrelated unit tests failing - will take a look at this PR today. |
| @@ -1910,6 +1911,10 @@ namespace Akka.Streams.Dsl | |||
| public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task> Ignore<TIn>() { } | |||
| public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task<TIn>> Last<TIn>() { } | |||
| public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task<TIn>> LastOrDefault<TIn>() { } | |||
| public static Akka.Streams.Dsl.Sink<TIn, System.Threading.Tasks.Task<Akka.Util.Option<TMat>>> LazyInitAsync<TIn, TMat>(System.Func<System.Threading.Tasks.Task<Akka.Streams.Dsl.Sink<TIn, TMat>>> sinkFactory) { } | |||
| [System.ObsoleteAttribute("Use LazyInitAsync instead. LazyInitAsync no more needs a fallback function and th" + | |||
| @@ -4188,6 +4193,17 @@ namespace Akka.Streams.Implementation.Fusing | |||
| protected override Akka.Streams.Stage.GraphStageLogic CreateLogic(Akka.Streams.Attributes inheritedAttributes) { } | |||
| } | |||
| [Akka.Annotations.InternalApiAttribute()] | |||
| public sealed class LazyFlow<TIn, TOut, TMat> : Akka.Streams.Stage.GraphStageWithMaterializedValue<Akka.Streams.FlowShape<TIn, TOut>, System.Threading.Tasks.Task<Akka.Util.Option<TMat>>> | |||
Currently, we have
LazySourceandLazySink. This PR adds the missingLazyFlowand theFlow.LazyInitAsyncstage that builds on top of it.Changes
Also,
Sink.LazyInitmaterialized value is a now wrapped in aTaskto clearly indicate whether the internal sink was materialized or not. It is marked deprecated in favor of the newSink.LazyInitAsync, aligned withFlow.LazyInitAsync.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksDon't apply.
This PR's Benchmarks
Don't apply.