Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct reference to Props in LocalActorRef #5556

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Remove direct reference to Props in LocalActorRef #5556

merged 2 commits into from
Feb 1, 2022

Conversation

Arkatufus
Copy link
Contributor

Fixes #5553

Changes

Remove reference to Props in LocalActorRef, this have a huge memory impact when LocalActorRef is being cached.

@Arkatufus
Copy link
Contributor Author

Before, snapshot taken at 2 minutes 52 seconds:
image

image

After, snapshot taken at 5 minutes 25 seconds:
image

image

Aaronontheweb
Aaronontheweb approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - very nice work

@Aaronontheweb Aaronontheweb merged commit dbe4999 into akkadotnet:dev Feb 1, 2022
@Aaronontheweb Aaronontheweb mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory leak in DistributedData on cross-node replication
2 participants
@Arkatufus @Aaronontheweb