Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Invalid cref values #5646

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Docs: Fix Invalid cref values #5646

merged 1 commit into from
Feb 11, 2022

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Feb 11, 2022

Part fix for #5542

@@ -84,7 +84,7 @@ public static DistributedPubSubSettings Create(Config config)
public string Role { get; }

/// <summary>
/// The routing logic to use for <see cref="DistributedPubSubMediator.Send"/>.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "real" invalid cref value issue

@@ -886,7 +886,7 @@ private sealed class NoDelta : IDeltaReplicatedData<IReplicatedData, IReplicated
/// and thereby violating <see cref="IRequireCausualDeliveryOfDeltas"/>.
///
/// This is used as a placeholder for such `null` delta. It's filtered out
/// in <see cref="DeltaPropagationSelector.CreateDeltaPropagation(ImmutableDictionary{string, Tuple{IReplicatedData, long, long}})"/>, i.e. never sent to the other replicas.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "real" invalid cref value issue

@@ -154,10 +154,10 @@ public interface IGetResponse : INoSerializationVerificationNeeded

/// <summary>
/// Tries to return a result of the request, given a replicated collection
/// <paramref name="key"/> used when sending a <see cref="Replicator.Get"/> request.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "real" invalid cref value issue

/// </summary>
/// <typeparam name="T">Replicated data.</typeparam>
/// <param name="key">Key send originally with a <see cref="Replicator.Get"/> request.</param>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a "real" invalid cref value issue

@Aaronontheweb Aaronontheweb merged commit 914b69b into akkadotnet:dev Feb 11, 2022
@eaba eaba deleted the invalid_cref_values branch February 12, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants