Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Akka/Akka#24722: Bugfix in VirtualProcessor #5950

Merged

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented May 18, 2022

Port of akka/akka#24722

This attempts to fix racy conditions observed in tests where subscribers sometime fails to subscribe to its publisher (probe.ExpectSubscriptionAsync() failed)

@Aaronontheweb
Copy link
Member

@Arkatufus can you resolve the conflicts on this branch?

…rocessor_#24722

# Conflicts:
#	src/core/Akka.Streams/Implementation/StreamLayout.cs
@Arkatufus
Copy link
Contributor Author

@Aaronontheweb done.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// | |
/// (1)| | (1)
/// v v
/// +---+----------+ (2) +-----+---------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New "Establishing" stage - got it.

@Aaronontheweb Aaronontheweb merged commit ed62940 into akkadotnet:dev May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants