[Akka.TestKit] TestKitBase should take arbitrary ActorSystem without throwing #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arkatufus does this also need to be ported to v1.4? |
|
It will be, yes |
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Sep 13, 2022
…throwing (akkadotnet#6092) (cherry picked from commit 015de37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Problem when passing arbitrary
ActorSysteminto a TestKit, it would throw aConfigurationExceptionbecause the TestKit HOCON configuration was not injected into theActorSystemChanges
TestKitBase._defaultConfigif the TestKit did not create theActorSystembeing tested