Fix GetEntityLocation use wrong actor path #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Sep 27, 2022
| @@ -1046,15 +1047,15 @@ async Task ResolveEntityRef(Address destinationAddress, ActorPath entityPath) | |||
| // NOTE: in the event that we're querying a shard's location from a ShardRegionProxy | |||
| // the shard may not be technically "homed" inside the proxy, but it does exist. | |||
| #pragma warning disable CS4014 | |||
| ResolveEntityRef(GetNodeAddress(shardRegionRef), shardRegionRef.Path / shardId / shardId); // needs to run as a detached task | |||
| ResolveEntityRef(GetNodeAddress(shardRegionRef), shardRegionRef.Path / shardId / entityId); // needs to run as a detached task | |||
There was a problem hiding this comment.
The actor path should be shardRegionRef.Path / shardId / entityId not shardRegionRef.Path / shardId / shardId
Arkatufus
commented
Sep 27, 2022
| #pragma warning restore CS4014 | ||
| } | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| #pragma warning disable CS4014 | ||
| ResolveEntityRef(GetNodeAddress(shardActorRef), shardActorRef.Path / shardId); // needs to run as a detached task | ||
| ResolveEntityRef(GetNodeAddress(shardActorRef), shardActorRef.Path / entityId); // needs to run as a detached task |
There was a problem hiding this comment.
Same here, actor path should be shardActorRef.Path / entityId, not shardActorRef.Path / shardId
Arkatufus
commented
Sep 27, 2022
| // must support ShardRegion.StartEntity in order for | ||
| // GetEntityLocation to work properly | ||
| case ShardRegion.StartEntity se: | ||
| return se.EntityId; | ||
| return (int.Parse(se.EntityId) % 10 + 1).ToString(); |
There was a problem hiding this comment.
Change the test IMessageExtractor so that the ShardId does not equal to EntityId to catch actor path bugs
There was a problem hiding this comment.
doh - that's a good catch
Aaronontheweb
approved these changes
Sep 27, 2022
Arkatufus
added a commit
to Arkatufus/akka.net
that referenced
this pull request
Sep 27, 2022
(cherry-picked from 86a0679)
Aaronontheweb
pushed a commit
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
GetEntityLocationdoes not work withHashCodeMessageExtractor