Backport v1.4.44 performance fixes to v1.5 #6162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP queue benchmarks * completed MailboxThroughputBenchmarks * disable `CallingThreadDispatcher`
* added parameterized Dispatcher benchmarks * fixed naming - also, pull all config from Akka defaults
…readPool` (akkadotnet#6143) Instead of having the `DedicatedThreadPool` operate on `Action` delegates, we now just take the `IRunnable` directly. Avoids a delegate allocation per-invocation.
purpose of this benchmark is not to measure processing time - it's meant to measure allocation pressure created by Akka.NET infrastructure: * `Envelope`s * `Mailbox` and `MessageDispatcher` overhead * `ActorCell` and `ActorBase` invocation overhead Ideally the memory pressure, given a `const string` as messaging input, should be close to zero - but between mailbox queue segment allocations, delegate + closure allocations, and probably some boxing we know that's not the case. Purpose of this benchmark is to measure that impact across threads.
* convert `Envelope` back into a reference type * approved API changes * changed to `readonly struct` * fixed API approvals
* close akkadotnet#2560 - added performance benchmarks for FSM * Improved FSM memory consumption * Made `Event` a `readonly struct` * Eliminated unnecessary `List<object>` allocations * Cleaned up XML-DOC comments * don't return new `State<TState, TData>` during `Stay()` * API approvals * fixed `State<TS.,TD>` errors
Aaronontheweb
commented
Oct 8, 2022
|
|
||
| private void RequestWorker() | ||
| { | ||
| _pool.QueueUserWorkItem(new RequestWorkerTask(this)); |
There was a problem hiding this comment.
Made RequestWorkerTask a class again @to11mtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.