Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate DefaultLogMessageFormatter allocations #6166

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Eliminate DefaultLogMessageFormatter allocations #6166

merged 3 commits into from
Oct 11, 2022

Conversation

Aaronontheweb
Copy link
Member

Changes

DefaultLogMessageFormatter is essentially a static class - removed its constructor and made it a singleton. This won't help with actor performance at all, but will reduce the total actor memory footprint especially in larger ActorSystems.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Oct 10, 2022
Arkatufus
Arkatufus approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) October 10, 2022 16:34
@Aaronontheweb
Copy link
Member Author

Aaronontheweb commented Oct 10, 2022 •
edited
Loading

The SerilogMessageFormatter has worked this way for years.

https://github.com/akkadotnet/Akka.Logger.Serilog/blob/32d7751d6c303fa49489826763d573083a199e41/src/Akka.Logger.Serilog/SerilogMessageFormatter.cs#L14-L26

@Aaronontheweb Aaronontheweb merged commit d82cdc2 into akkadotnet:dev Oct 11, 2022
@Aaronontheweb Aaronontheweb deleted the logging-refactor branch October 11, 2022 12:19
@Arkatufus Arkatufus mentioned this pull request Oct 11, 2022
Merged
Aaronontheweb added a commit that referenced this pull request Oct 12, 2022
@Arkatufus @Aaronontheweb
[BACKPORT #6166] Eliminate DefaultLogMessageFormatter allocations (#…
7e9e58f 
…6168)

* cherry-picked from d82cdc2

* Update API Verify list

Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

Assignees
No one assigned
Labels
akka-actor perf
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Aaronontheweb @Arkatufus