.NET 6: PeriodicTimer scheduler replacement for dedicated thread
#6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this on the build server first to see if the .NET 6 impl falls apart compared to .NET Framework and .NET Core 3.1 |
|
Measured clock drift for |
|
I must have written something wrong in this implementation of the timer - it is taking an eternity for ticks to be processed. |
5 tasks
* Fix implementation and code cleanup * Fix clock drift calculation
|
Measured clock drift on old code path in this PR: |
|
Measured clock drift on new code path in this PR: |
|
@Arkatufus have approximately 20 test failures on this PR - can you run locally? |
|
will do |
Aaronontheweb
commented
Aug 21, 2023
| @@ -52,6 +52,9 @@ public HashedWheelTimerScheduler(Config scheduler, ILoggingAdapter log) : base(s | |||
| if (SchedulerConfig.IsNullOrEmpty()) | |||
| throw ConfigurationException.NullOrEmptyConfig<HashedWheelTimerScheduler>(); | |||
|
|
|||
| if (!Util.MonotonicClock.IsHighResolution) | |||
| Log.Warning("HashedWheelTimerScheduler depends on the availability of high resolution performance counter which is not available in this system"); | |||
There was a problem hiding this comment.
When would the high resolution timer not be available?
There was a problem hiding this comment.
When the runtime could not provide one
There was a problem hiding this comment.
Is it not able to provide one on the build server?
There was a problem hiding this comment.
No idea, but its there as a preventative measures, just in case this happens in the future
Aaronontheweb
commented
Aug 22, 2023
|
|
||
| _shutdownTimeout = SchedulerConfig.GetTimeSpan("akka.scheduler.shutdown-timeout", null); | ||
| _shutdownTimeout = SchedulerConfig.GetTimeSpan("akka.scheduler.shutdown-timeout", TimeSpan.Zero); |
There was a problem hiding this comment.
So this will result in an instant shutdown?
There was a problem hiding this comment.
Yes, it would, because TimeSpan.Zero is an illegal value
|
|
||
| static MonotonicClock() | ||
| { | ||
| TicksFrequency = (double)TicksInSecond / Stopwatch.Frequency; |
There was a problem hiding this comment.
Why is this here? Please add a comment in the code to explain, as it's non-obvious why this is needed.
There was a problem hiding this comment.
TickFrequency is a constant scaling value to normalize operating system reported performance counter clock tick to .NET internal definition of a "tick".
Stopwatch.ElapsedTicks returns the raw operating system level performance clock ticks, which is not the same definition as .NET DateTime or TimeSpan definition.
.NET DateTime or TimeSpan definition of a "tick" is 100 nanosecond, which is true for all windows platforms that support performance counter clock (win8+). This is not true for linux platforms, their definition of a "tick" is 1 nanosecond.
…akka.net into threading-timer-scheduler
|
Can you run the |
RemotePingPong BenchmarkMedian value of 5 benchmark runs Benchmark ComputerOSVersion: Microsoft Windows NT 10.0.19045.0 Dev Branch
New Code
|
|
Benchmark numbers look good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #4031
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.