Fix persistence allocations part 2. #6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0b0s
changed the title
to11mtm
approved these changes
Mar 5, 2023
| public bool Equals(WriteMessages other) | ||
| { | ||
| if (ReferenceEquals(other, null)) return false; | ||
| if (ReferenceEquals(this, other)) return true; | ||
|
|
||
| return Equals(ActorInstanceId, other.ActorInstanceId) | ||
| return ActorInstanceId == other.ActorInstanceId |
There was a problem hiding this comment.
Rider highligths such cases
| { | ||
| _journalBatch.Add(p); | ||
| } | ||
| _eventBatch = new LinkedList<IPersistentEnvelope>(); | ||
| _eventBatch.Clear(); |
| @@ -341,7 +341,7 @@ private void HandleWriteMessages(WriteMessages message) | |||
| */ | |||
| var self = Self; | |||
| _resequencerCounter += message.Messages.Aggregate(1, (acc, m) => acc + m.Size); | |||
| var atomicWriteCount = message.Messages.OfType<AtomicWrite>().Count(); | |||
| var atomicWriteCount = message.Messages.Count(x => x is AtomicWrite); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Next optimization of persistence allocation that was started in #5505
Now excessive object allocation was eliminated in Eventsourced class when using linked list. Benchmark shows kinda 10% lower memory usage.
Checklist
Latest
devBenchmarksBenchmarkDotNet=v0.13.2, OS=macOS Monterey 12.5.1 (21G83) [Darwin 21.6.0]
Apple M1 2.40GHz, 1 CPU, 8 logical and 8 physical cores
.NET SDK=7.0.101
[Host] : .NET 7.0.1 (7.0.122.56804), X64 RyuJIT SSE4.2 DEBUG
Toolchain=InProcessEmitToolchain InvocationCount=1 UnrollFactor=1
This PR's Benchmarks
BenchmarkDotNet=v0.13.2, OS=macOS Monterey 12.5.1 (21G83) [Darwin 21.6.0]
Apple M1 2.40GHz, 1 CPU, 8 logical and 8 physical cores
.NET SDK=7.0.101
[Host] : .NET 7.0.1 (7.0.122.56804), X64 RyuJIT SSE4.2 DEBUG
Toolchain=InProcessEmitToolchain InvocationCount=1 UnrollFactor=1