Akka.Actor: IStash API and configuration enhancements
#6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add APIs to track content of Stash
|
Have the data APIs and use cases ready to go, as those were pretty easy. Working on the deployment / configuration pieces now. |
Aaronontheweb
commented
Apr 21, 2023
| @@ -1134,6 +1134,11 @@ namespace Akka.Actor | |||
| } | |||
| public interface IStash | |||
| { | |||
| int Capacity { get; } | |||
There was a problem hiding this comment.
New stashing APIs. Pretty self-explanatory.
| @@ -695,6 +695,12 @@ public void Prepend(IEnumerable<Envelope> envelopes) | |||
| { | |||
| _userStash.Prepend(envelopes); | |||
| } | |||
|
|
|||
| public int Count => _userStash.Count; | |||
There was a problem hiding this comment.
For the Eventsourced stash, we use the values provided for the user stash rather than the internal one (since the user can't really affect the internal stash anyway.)
| } | ||
|
|
||
| [Fact] | ||
| public async Task ShouldGetAccurateStashReadingForUnboundedStash() |
There was a problem hiding this comment.
Basic happy path stash spec. Going to add one for dealing with bounded stashes once I get the other half of #6658
|
I'll document the new config API in a separate PR. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #6658 - expose data about the contents of the stash and make it easier to configure bounded stashes.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
IStashimprovements - programmatic bounded stash configuration and stash capacity APIs #6658