Fix LocalSnapshotStore Metadata Fetch to ensure persistenceid match. #7040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7009
Changes
Adds an additional filter check to getting snapshot metadata to ensure persistenceId matches.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
No benchmarks:
LocalSnapshot store is not meant to be performant. That said, I think one can agree that the additional
.Where()
call is dwarfed by existing regex and IO in this operation. If we want this to be 'faster' we should consider instead unrolling the LINQ block into something less capture-y.