Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocalSnapshotStore Metadata Fetch to ensure persistenceid match. #7040

Merged

Conversation

to11mtm
Copy link
Member

@to11mtm to11mtm commented Jan 7, 2024

Fixes #7009

Changes

Adds an additional filter check to getting snapshot metadata to ensure persistenceId matches.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

No benchmarks:

LocalSnapshot store is not meant to be performant. That said, I think one can agree that the additional .Where() call is dwarfed by existing regex and IO in this operation. If we want this to be 'faster' we should consider instead unrolling the LINQ block into something less capture-y.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review January 8, 2024 14:20
@Aaronontheweb
Copy link
Member

Test failures were unrelated Akka.Persistence.TestKit.Tests, which are being addressed at #7037

@Aaronontheweb Aaronontheweb merged commit 97323d1 into akkadotnet:dev Jan 8, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while recovering snapshots for actors with particular format for PersistenceId
2 participants