Fix missing HandOverDone handler in ClusterSingletonManager
#7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jun 5, 2024
| return Stay(); | ||
| } | ||
| else if (e.FsmEvent is MemberDowned memberDowned && e.StateData is OldestData od && memberDowned.Member.UniqueAddress.Equals(_cluster.SelfUniqueAddress)) | ||
| switch (e.FsmEvent) |
There was a problem hiding this comment.
Convert if..else structure to switch..case (auto-refactor, no code change)
Comment on lines
+1225
to
+1229
| case HandOverDone: | ||
| // no-op, the HandOverDone message can be sent multiple times if HandOverToMe | ||
| // was sent multiple times (retried) | ||
| // https://github.com/akka/akka/pull/29216/files#r440062592 | ||
| return Stay(); |
There was a problem hiding this comment.
Actual fix, do a no-op when extra HandOverDone is received
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6973 (comment)
Changes
Add
HandOverDonemessage handler to ClusterSingletonManager Oldest state