Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Serialization.DeserializeActorRef method #7237

Merged

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Jun 7, 2024

Changes

Designed to give us a more aligned API for end-users that need to serialize and deserialize IActorRefs in their own user-defined messages.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Designed to give us a more aligned API for end-users that need to serialize and deserialize `IActorRef`s in their own user-defined messages.
Copy link
Member Author

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API change doesn't introduce any new functionality or alter any existing ones - it just makes it easier to find everything you need to manage IActorRef serialization in a single place.

@@ -699,7 +699,7 @@ private static string ShardIdMessageFromBinary(byte[] bytes)

private IActorRef ResolveActorRef(string path)
{
return system.Provider.ResolveActorRef(path);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm writing docs for the new Akka.NET website on IActorRef serialization and it's very disjointed - we use Serialization.SerializedActorPath to serialize actors and ExtendedActorSystem.Provider.DeserializeActorRef. I wanted to put an access point for both of these functions (actor reference serialization and deserialization) so it makes more sense to end-users trying to handle this problem on their own.

@Aaronontheweb Aaronontheweb added this to the 1.5.24 milestone Jun 7, 2024
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) June 7, 2024 14:23
@Aaronontheweb Aaronontheweb merged commit e144c5d into akkadotnet:dev Jun 7, 2024
8 of 12 checks passed
@Aaronontheweb Aaronontheweb deleted the simplified-actor-serialization branch June 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants