-
Notifications
You must be signed in to change notification settings - Fork 1.1k
better perf in HandleStashedInbound #7409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaronontheweb
merged 2 commits into
akkadotnet:dev
from
SimonCropp:better-perf-in-HandleStashedInbound
Dec 18, 2024
Merged
better perf in HandleStashedInbound #7409
Aaronontheweb
merged 2 commits into
akkadotnet:dev
from
SimonCropp:better-perf-in-HandleStashedInbound
Dec 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SimonCropp
commented
Dec 16, 2024
- remove 1 dictionary lookup. since previously GetOrElse and Remove are a dictionary lookup
- remove redundant list allocation
- remove redundant enumeration over the above empty list
Aaronontheweb
approved these changes
Dec 18, 2024
Member
Aaronontheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
Test failure was not related to this spec - it's an Akka.Streams spec that's tightly bounded to timings, which makes it somewhat inherently racy. |
This was referenced Oct 7, 2025
This was referenced Oct 7, 2025
This was referenced Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.