[WIP]: resolve ThrottlerTransportAdapter NRE
#7565
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This change is going to involve updating some |
Aaronontheweb
commented
Mar 23, 2025
Member
Author
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Commented on some safety fixes around Nobody
| public sealed class Nobody : Akka.Actor.MinimalActorRef | ||
| { | ||
| public static Akka.Actor.Nobody Instance; | ||
| public static readonly Akka.Actor.Nobody Instance; |
Member
Author
There was a problem hiding this comment.
Never should have been mutable
| public override Akka.Actor.ActorPath Path { get; } | ||
| public override Akka.Actor.IActorRefProvider Provider { get; } | ||
| public override Akka.Util.ISurrogate ToSurrogate(Akka.Actor.ActorSystem system) { } | ||
| public class NobodySurrogate : Akka.Util.ISurrogate |
Member
Author
There was a problem hiding this comment.
Never needed to be part of the public API - just the ISurrogate interface is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #7564
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):