Skip to content

Props - Remove usage of expressions #7577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
+59 −114
Draft

Props - Remove usage of expressions #7577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a370d7
First pass at getting rid of expressions
mhbuck Mar 24, 2025
24d14a5
Adding method where actor created without args.
mhbuck Mar 25, 2025
d241d73
Minor rename and removal of non referenced object.
mhbuck Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/core/Akka.TestKit/TestKitBase_ActorOf.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
//-----------------------------------------------------------------------

using System;
using System.Linq.Expressions;
using Akka.Actor;
using Akka.Actor.Dsl;

Expand Down Expand Up @@ -71,7 +70,7 @@ public IActorRef ActorOf(Props props, string name)
/// <typeparam name="TActor">The type of the actor.</typeparam>
/// <param name="factory">An expression that calls the constructor of <typeparamref name="TActor"/></param>
/// <returns>TBD</returns>
public IActorRef ActorOf<TActor>(Expression<Func<TActor>> factory) where TActor : ActorBase
public IActorRef ActorOf<TActor>(Func<TActor> factory) where TActor : ActorBase
{
return Sys.ActorOf(Props.Create(factory), null);
}
Expand All @@ -87,7 +86,7 @@ public IActorRef ActorOf<TActor>(Expression<Func<TActor>> factory) where TActor
/// <param name="factory">An expression that calls the constructor of <typeparamref name="TActor"/></param>
/// <param name="name">The name of the actor.</param>
/// <returns>TBD</returns>
public IActorRef ActorOf<TActor>(Expression<Func<TActor>> factory, string name) where TActor : ActorBase
public IActorRef ActorOf<TActor>(Func<TActor> factory, string name) where TActor : ActorBase
{
return Sys.ActorOf(Props.Create(factory), name);
}
Expand Down Expand Up @@ -201,7 +200,7 @@ public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Props props, string na
/// <param name="supervisor">The supervisor</param>
/// <param name="name">Optional: The name.</param>
/// <returns>TBD</returns>
public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Expression<Func<TActor>> factory, IActorRef supervisor, string name = null) where TActor : ActorBase
public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Func<TActor> factory, IActorRef supervisor, string name = null) where TActor : ActorBase
{
return new TestActorRef<TActor>(Sys, Props.Create(factory), supervisor, name);
}
Expand All @@ -218,7 +217,7 @@ public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Expression<Func<TActor
/// <param name="factory">An expression that calls the constructor of <typeparamref name="TActor"/></param>
/// <param name="name">Optional: The name.</param>
/// <returns>TBD</returns>
public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Expression<Func<TActor>> factory, string name = null) where TActor : ActorBase
public TestActorRef<TActor> ActorOfAsTestActorRef<TActor>(Func<TActor> factory, string name = null) where TActor : ActorBase
{
return new TestActorRef<TActor>(Sys, Props.Create(factory), NoSupervisor, name);
}
Expand Down Expand Up @@ -333,7 +332,7 @@ public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TStat
/// <param name="name">Optional: The name.</param>
/// <param name="withLogging">Optional: If set to <c>true</c> logs state changes of the FSM as Debug messages. Default is <c>false</c>.</param>
/// <returns>TBD</returns>
public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TState, TData>(Expression<Func<TFsmActor>> factory, IActorRef supervisor, string name = null, bool withLogging = false)
public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TState, TData>(Func<TFsmActor> factory, IActorRef supervisor, string name = null, bool withLogging = false)
where TFsmActor : FSM<TState, TData>
{
return new TestFSMRef<TFsmActor, TState, TData>(Sys, Props.Create(factory), supervisor, name, withLogging);
Expand All @@ -351,7 +350,7 @@ public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TStat
/// <param name="name">Optional: The name.</param>
/// <param name="withLogging">Optional: If set to <c>true</c> logs state changes of the FSM as Debug messages. Default is <c>false</c>.</param>
/// <returns>TBD</returns>
public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TState, TData>(Expression<Func<TFsmActor>> factory, string name = null, bool withLogging = false)
public TestFSMRef<TFsmActor, TState, TData> ActorOfAsTestFSMRef<TFsmActor, TState, TData>(Func<TFsmActor> factory, string name = null, bool withLogging = false)
where TFsmActor : FSM<TState, TData>
{
return new TestFSMRef<TFsmActor, TState, TData>(Sys, Props.Create(factory), NoSupervisor, name, withLogging);
Expand Down
Loading
Loading