[TestKit] Enable nullability for Akka.TestKit.EventFilter.Internal #7779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Looks like some comments got removed and replaced with TBDs, which we're trying to avoid
| private readonly string _s; | ||
|
|
||
| /// <summary> | ||
| /// <remarks>Note! Part of internal API. Breaking changes may occur without notice. Use at own risk.</remarks> |
| private readonly bool _canBeRelative; | ||
|
|
||
| /// <summary> | ||
| /// <remarks>Note! Part of internal API. Breaking changes may occur without notice. Use at own risk.</remarks> |
Member
There was a problem hiding this comment.
Same, why did this get removed and replaced with a TBD comment?
| public interface IStringMatcher | ||
| { | ||
| /// <summary> | ||
| /// <remarks>Note! Part of internal API. Breaking changes may occur without notice. Use at own risk.</remarks> |
Member
|
@Arkatufus disregard my previous review - I can see that those issues are not issues when I have whitespace disabled on the reviewer UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7777
Changes
Enable nullability