fix Replicator.ReceiveUnsubscribe boolean logic
#7806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Sep 4, 2025
| Context.Unwatch(subscriber); | ||
|
|
||
| if (!_subscribers.ContainsKey(key.Id) || !_newSubscribers.ContainsKey(key.Id)) | ||
| if (!_subscribers.ContainsKey(key.Id) && !_newSubscribers.ContainsKey(key.Id)) |
Member
Author
There was a problem hiding this comment.
We should only remove the subscription key if the subscription is found in NEITHER of these collections.
Member
Author
|
Will need to backport this to the v1.5 branch as well. |
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Sep 4, 2025
3 tasks
Member
Author
|
Backport: #7809 |
Aaronontheweb
added a commit
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7804
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
KeyNotFoundExceptioninDistributedData Replicator.Notify()due to inconsistent subscription state #7804