Skip to content

[DRAFT] Test: Remove ConfigureAwait(false) only - no locking changes #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Test: Remove ConfigureAwait(false) only - no locking changes #7896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/Akka.Persistence/Journal/AsyncWriteJournal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,10 @@ private async Task ExecuteBatch(WriteMessages message, int atomicWriteCount, IAc
// try in case AsyncWriteMessages throws
try
{
var writeResult =
await _breaker.WithCircuitBreaker((prepared, awj: this), (state, ct) => state.awj.WriteMessagesAsync(state.prepared, ct)).ConfigureAwait(false);
// NOTE: Not using ConfigureAwait(false) to ensure continuation runs on actor's dispatcher thread.
// This ensures proper synchronization context and avoids potential race conditions and deadlocks.
var writeResult =
await _breaker.WithCircuitBreaker((prepared, awj: this), (state, ct) => state.awj.WriteMessagesAsync(state.prepared, ct));

ProcessResults(writeResult, atomicWriteCount, message, _resequencer, resequencerCounter, self);
}
Expand Down