Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ingress values and implementation #1142

Merged
merged 1 commit into from
Jul 14, 2024
Merged

update ingress values and implementation #1142

merged 1 commit into from
Jul 14, 2024

Conversation

vordimous
Copy link
Contributor

@vordimous vordimous commented Jul 11, 2024

Description

This improves the ingress controller to allow for managing ingress without a host specified. It also enables defining paths that can map to different ports down to the K8s zilla service. Additionally, it supports backward-compatible K8s versions of ingress.

Notes output with multiple ingress paths defined:

Zilla is available through an ingress controller at the base url(s):
  http://localhost/api
  http://localhost/ui

Notes output when no ingress is configured, the command dynamically forwards any exposed Zilla service ports:

Connect to Zilla by running these commands:
  export SERVICE_PORTS=$(kubectl get svc --namespace $namespace $service_name --template "{{ range .spec.ports }}{{.port}} {{ end }}")
  eval "kubectl port-forward --namespace $namespace service/$service_name $SERVICE_PORTS"

@vordimous vordimous marked this pull request as ready for review July 14, 2024 16:19
@vordimous vordimous requested a review from jfallows July 14, 2024 16:20
@jfallows jfallows merged commit 11ad955 into develop Jul 14, 2024
5 checks passed
@vordimous vordimous deleted the helm-ingress branch July 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants