fix: fix schema syntax and naming #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vordimous
commented
Aug 27, 2024
...rpc.spec/src/main/scripts/io/aklivity/zilla/specs/binding/grpc/schema/grpc.schema.patch.json
Outdated
Show resolved
Hide resolved
vordimous
commented
Aug 27, 2024
...ec/src/main/scripts/io/aklivity/zilla/specs/binding/openapi/schema/openapi.schema.patch.json
Show resolved
Hide resolved
vordimous
commented
Aug 27, 2024
...rpc.spec/src/main/scripts/io/aklivity/zilla/specs/binding/grpc/schema/grpc.schema.patch.json
Outdated
Show resolved
Hide resolved
vordimous
force-pushed
the
schema-syntax-edits
branch
from
ba64a29 to
25f70b3
Compare
vordimous
force-pushed
the
schema-syntax-edits
branch
from
25f70b3 to
28c8a4e
Compare
vordimous
commented
Aug 30, 2024
.../main/scripts/io/aklivity/zilla/specs/binding/grpc/kafka/schema/grpc.kafka.schema.patch.json
Show resolved
Hide resolved
vordimous
force-pushed
the
schema-syntax-edits
branch
from
496c0d9 to
b882837
Compare
vordimous
commented
Sep 9, 2024
runtime/engine/src/main/java/io/aklivity/zilla/runtime/engine/config/EngineConfigAnnotator.java
Show resolved
Hide resolved
vordimous
force-pushed
the
schema-syntax-edits
branch
from
a92bdd5 to
945d99e
Compare
jfallows
requested changes
Sep 9, 2024
...rpc.spec/src/main/scripts/io/aklivity/zilla/specs/binding/grpc/schema/grpc.schema.patch.json
Outdated
Show resolved
Hide resolved
...ttp.spec/src/main/scripts/io/aklivity/zilla/specs/binding/http/schema/http.schema.patch.json
Outdated
Show resolved
Hide resolved
...ttp.spec/src/main/scripts/io/aklivity/zilla/specs/binding/http/schema/http.schema.patch.json
Outdated
Show resolved
Hide resolved
...a.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json
Outdated
Show resolved
Hide resolved
...g-tcp.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tcp/schema/tcp.schema.patch.json
Outdated
Show resolved
Hide resolved
...ls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/config/client.alpn.default.yaml
Show resolved
Hide resolved
...ls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/config/server.alpn.default.yaml
Show resolved
Hide resolved
...g-tls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/schema/tls.schema.patch.json
Outdated
Show resolved
Hide resolved
...g-tls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/schema/tls.schema.patch.json
Outdated
Show resolved
Hide resolved
specs/engine.spec/src/main/scripts/io/aklivity/zilla/specs/engine/schema/engine.schema.json
Outdated
Show resolved
Hide resolved
…cs/binding/http/schema/http.schema.patch.json Co-authored-by: John Fallows <john@aklivity.io>
vordimous
force-pushed
the
schema-syntax-edits
branch
from
03a088c to
75b93d2
Compare
…x-edits # Conflicts: # specs/binding-tls.spec/src/main/scripts/io/aklivity/zilla/specs/binding/tls/schema/tls.schema.patch.json
This reverts commit 4ec3456.
…x-edits # Conflicts: # specs/binding-kafka.spec/src/main/scripts/io/aklivity/zilla/specs/binding/kafka/schema/kafka.schema.patch.json
vordimous
force-pushed
the
schema-syntax-edits
branch
from
3a31cb1 to
bdd12da
Compare
jfallows
requested changes
Sep 13, 2024
...ttp.spec/src/main/scripts/io/aklivity/zilla/specs/binding/http/schema/http.schema.patch.json
Outdated
Show resolved
Hide resolved
Comment on lines
196
to
201
| "entry": | ||
| { | ||
| "title": "Entry", | ||
| "type": "string", | ||
| "pattern": "^[a-zA-Z]+[a-zA-Z0-9\\._\\-]*$" | ||
| } |
There was a problem hiding this comment.
Let's define this once at engine.schema.json level for any binding with REMOTE_SERVER kind, instead of defining separately per binding.
There was a problem hiding this comment.
This should have been removed from a revert commit. It is defined back the way it was.
vordimous
force-pushed
the
schema-syntax-edits
branch
from
f68d07f to
4ee2ffa
Compare
vordimous
force-pushed
the
schema-syntax-edits
branch
from
4ee2ffa to
23d1695
Compare
jfallows
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When comparing the zilla schema to the docs there were some syntax and naming inconsistencies. These changes address them.
Refer to the live reference docs update for implementation of docs types and defaults: https://vordimous.github.io/zilla-docs/next/reference/config/overview.html