Risingwave demo bug fixes #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
previously approved these changes
Sep 19, 2024
jfallows
previously approved these changes
Sep 19, 2024
jfallows
requested changes
Sep 19, 2024
Comment on lines
103
to
106
| [0x69 0x64] # Data | ||
| [0x00 0x00 0x00 0x011] # Length | ||
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67 # Data | ||
| [0xff 0xff 0xff 0xff] # Length |
There was a problem hiding this comment.
Suggested change
| [0x69 0x64] # Data | |
| [0x00 0x00 0x00 0x011] # Length | |
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67 # Data | |
| [0xff 0xff 0xff 0xff] # Length | |
| "id" # Data | |
| [0x00 0x00 0x00 0x011] # Length | |
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67 # Data | |
| [0xff 0xff 0xff 0xff] # Length |
etc for other strings
jfallows
requested changes
Sep 20, 2024
| .build() | ||
| .build()} | ||
| read [0x00 0x04] # Field Count | ||
| [0x00 0x00 0x00 0x04] # Length | ||
| [0x63 0x69 0x74 0x79] # Data |
| [0x00 0x00 0x00 0x04] # Length | ||
| [0x63 0x69 0x74 0x79] # Data | ||
| [0x00 0x00 0x00 0x11] # Length | ||
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67] # Data |
| [0x00 0x00 0x00 0x02] # Length | ||
| "id" # Data | ||
| [0x00 0x00 0x00 0x11] # Length | ||
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67] # Data |
| [0x00 0x00 0x00 0x02] # Length | ||
| "id" # Data | ||
| [0x00 0x00 0x00 0x11] # Length | ||
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67] # Data |
| .build()} | ||
| write [0x00 0x04] # Field Count | ||
| [0x00 0x00 0x00 0x04] # Length | ||
| [0x63 0x69 0x74 0x79] # Data |
| [0x00 0x00 0x00 0x04] # Length | ||
| [0x63 0x69 0x74 0x79] # Data | ||
| [0x00 0x00 0x00 0x11] # Length | ||
| [0x63 0x68 0x61 0x72 0x61 0x63 0x74 0x65 0x72 0x20 0x76 0x61 0x72 0x79 0x69 0x6e 0x67] # Data |
Comment on lines
+27
to
+33
| TYPE_MAPPINGS.put("character varying", "VARCHAR"); | ||
| TYPE_MAPPINGS.put("integer", "INT"); | ||
| TYPE_MAPPINGS.put("boolean", "BOOL"); | ||
| TYPE_MAPPINGS.put("character", "CHAR"); | ||
| TYPE_MAPPINGS.put("timestamp without time zone", "TIMESTAMP"); | ||
| TYPE_MAPPINGS.put("timestamp with time zone", "TIMESTAMPZ"); | ||
| TYPE_MAPPINGS.put("double precision", "DOUBLE"); |
jfallows
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.